Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TranslationChartImage #13734

Closed
4 tasks
Tracked by #13043
corwintines opened this issue Aug 28, 2024 · 4 comments · Fixed by #13774
Closed
4 tasks
Tracked by #13043

TranslationChartImage #13734

corwintines opened this issue Aug 28, 2024 · 4 comments · Fixed by #13774
Assignees
@Baystef
Labels
needs triage 📥 This issue needs triaged before being worked on

Comments

@corwintines
Copy link
Member

corwintines commented Aug 28, 2024 •
edited
Loading

Create story tests for TranslationChartImage

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/TranslationChartImage.tsx to /src/components/TranslationChartImage/index.tsx
  • Fix any filepath changes to imports for the TranslationChartImage
  • Create story file `/src/components/TranslationChartImage/TranslationChartImage.stories.tsx
  • Write story testing render of the TranslationChartImage component in context of use
@corwintines corwintines mentioned this issue Aug 28, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 28, 2024
@corwintines
Copy link
Member Author

@Baystef if you comment here I can assign to you

@Baystef
Copy link
Contributor

Baystef commented Aug 28, 2024

@Baystef if you comment here I can assign to you

Kindly assign to me @corwintines . Thanks

@Baystef Baystef mentioned this issue Sep 2, 2024
Merged
4 tasks
corwintines added a commit that referenced this issue Sep 3, 2024
@corwintines
Merge pull request #13774 from Baystef/feat/translationchartimage-story
79e057d 
Create story tests for TranslationChartImage component [#13734]
This was referenced Sep 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baystef Baystef

Labels
needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create story tests for TranslationChartImage component [#13734] Baystef/ethereum-org-website
7 participants
@corwintines @Baystef and others