Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StatsBoxGrid stories #13668

Closed
minimalsm opened this issue Aug 16, 2024 · 0 comments · Fixed by #13669
Closed

Remove StatsBoxGrid stories #13668

minimalsm opened this issue Aug 16, 2024 · 0 comments · Fixed by #13669
Assignees
Labels
needs triage 📥 This issue needs triaged before being worked on

Comments

@minimalsm
Copy link
Contributor

Description

Currently, the StatBoxs grid component uses Date.now, which causes the stories to fully re-run every time, even when the component hasn't changed. This behavior prevents Turbosnaps from functioning properly because the component receives a new date on every run.

Proposed Solution

As we're developing a new, simpler stats component for the new homepage, we should delete these stories for now to mitigate the issue. Removing these stories will stop the unnecessary re-runs and enable Turbosnaps to function as intended.

Steps to Reproduce

  • Observe that the stories for StatBoxs grid component are re-run every time, due to the use of Date.now.
  • Notice that this prevents Turbosnaps from working efficiently.

Additional Context

This is a temporary measure to avoid unnecessary re-runs while we work on the new stats component for the homepage. Once the new component is in place, this issue should no longer occur.

@minimalsm minimalsm self-assigned this Aug 16, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant