Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: remove date from whitepaper page #13645

Closed
1 of 2 tasks
konopkja opened this issue Aug 15, 2024 · 9 comments · Fixed by #13710
Closed
1 of 2 tasks

Bug report: remove date from whitepaper page #13645

konopkja opened this issue Aug 15, 2024 · 9 comments · Fixed by #13710
Assignees
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing

Comments

@konopkja
Copy link
Contributor

konopkja commented Aug 15, 2024

Describe the bug

We have a date component that showcases when was a page last edited, however on whitepaper page this may be confusing to users leading them to believe the whitepaper has been updated with new information.

THerefore we should remove the component from this page.

To reproduce

  1. Go to https://ethereum.org/en/whitepaper/
  2. See date on top of the page

Expected behavior

remove date (OR instead hard code static date of when the whitepaper has been published.)

Screenshots

Screenshot 2024-08-15 at 11 19 45

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing dev required This requires developer resources labels Aug 15, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 15, 2024
@gks2022004
Copy link
Contributor

I solve it, assign it to me please

@konopkja
Copy link
Contributor Author

I solve it, assign it to me please

assigned, thank you!

@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Aug 16, 2024
@gks2022004
Copy link
Contributor

I could not find the 'whitepaper' page, to remove the date, need help😅

@konopkja
Copy link
Contributor Author

konopkja commented Aug 19, 2024

I could not find the 'whitepaper' page, to remove the date, need help😅

https://ethereum.org/en/whitepaper/ or do you mean in repo?

@gks2022004
Copy link
Contributor

gks2022004 commented Aug 19, 2024

Yes, in the main repository where I have to fix the issue, from the repo I get the idea of working, that the whitepaper pdf or json is fetched on the hero section of WhitePaper.
@wackerow @pettinarip

@konopkja
Copy link
Contributor Author

cc @wackerow @pettinarip for help

@corwintines
Copy link
Member

Hey @gks2022004

The area where this is rendered can be found here

{lastEditLocaleTimestamp}

I think all that needs to be done is conditionally render this where if the slug is /whitepaper it isnt rendered, otherwise render.

@gks2022004
Copy link
Contributor

Thanks, for the help

@gks2022004
Copy link
Contributor

gks2022004 commented Aug 23, 2024

@wackerow @konopkja @minimalsm
I have created the PR

corwintines added a commit that referenced this issue Sep 4, 2024
fix: Remove date from whitepaper page #13645
This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants