Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7742: update the required EL headers and the gas fee mechanism #8994

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Oct 23, 2024

an alternate and more simplified proposal to #8979

based on the discussion with @bkellerman here:

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 23, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 23, 2024

File EIPS/eip-7742.md

Requires 1 more reviewers from @ralexstokes

@bkellerman
Copy link
Contributor

bkellerman commented Oct 25, 2024

LGTM!

EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated
else
normalizedParentExcessBlobGas = parent.excess_blob_gas
targetBlobGas = parent.target_blob_count * GAS_PER_BLOB
maxExcessGasDiffPossible = max(parent.max_blob_count - parent.target_blob_count, parent.target_blob_count) * GAS_PER_BLOB
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does parent.max_blob_count imply we need to store the max_blob_count on the EL header now?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this now need to involve max? What value are we getting from the extra complexity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need max for max versioned hash validations and for excess blob gas computation validation in optimistic scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants