Update EIP-7742: update the required EL headers and the gas fee mechanism #8994
+55
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
File
|
|
LGTM! |
siladu
reviewed
Oct 28, 2024
ralexstokes
reviewed
Oct 28, 2024
ralexstokes
reviewed
Oct 28, 2024
siladu
reviewed
Oct 29, 2024
EIPS/eip-7742.md
Outdated
| else | ||
| normalizedParentExcessBlobGas = parent.excess_blob_gas | ||
| targetBlobGas = parent.target_blob_count * GAS_PER_BLOB | ||
| maxExcessGasDiffPossible = max(parent.max_blob_count - parent.target_blob_count, parent.target_blob_count) * GAS_PER_BLOB |
There was a problem hiding this comment.
Does parent.max_blob_count imply we need to store the max_blob_count on the EL header now?
There was a problem hiding this comment.
Why does this now need to involve max? What value are we getting from the extra complexity?
There was a problem hiding this comment.
we need max for max versioned hash validations and for excess blob gas computation validation in optimistic scenarios
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an alternate and more simplified proposal to #8979
based on the discussion with @bkellerman here: