Add EIP: GAS2ETH opcode #8980
Add EIP: GAS2ETH opcode #8980
Conversation
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Amend `GAS2ETH` Proposal
File
|
Co-authored-by: Andrew B Coathup <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
github-actions
bot
added
c-new
eth-bot
added
e-consensus
|
The commit 3a58567 (as a parent of 95e214f) contains errors. |
|
|
||
| - Pops two values from the stack: `addr` then `gas_amount`. If there are fewer than two values on the stack, the calling context should fail with stack underflow. | ||
| - Deducts `gas_amount` from the current calling context. | ||
| - Computes `wei_val` by multiplying `gas_amount` by the current transaction context's `gas_price`. |
There was a problem hiding this comment.
What is the gas price? Is this the base fee? Or is this the tip? Or is it both?
| - If the gas cost of this opcode + `gas_amount` is greater than the available gas in the current calling context, the calling context should fail with "out-of-gas" and any state changes reverted. | ||
| - Pushes `wei_val` onto the stack. | ||
|
|
||
| Note that the transfer of `wei_val` to the given account cannot fail. In particular, the destination account code (if any) is not executed, or, if the account does not exist, the balance is still added to the given address `addr`. |
There was a problem hiding this comment.
There is extra gas cost in CALL if the call sends value and a new address is created in the trie. I think this should be added here as well.
|
|
||
| The proposed cost of this opcode is similar to the recently proposed `PAY` opcode, but changing the base cost from `9000` to `2400`. That is: | ||
|
|
||
| - The base cost of this opcode is `2400`. This is priced so that invoking `GAS2ETH` on a cold account costs the same as a cold `SSTORE`. |
There was a problem hiding this comment.
SSTORE cold on a storage slot which is currently nonzero changing to another nonzero value costs 5000 gas (if its warm: 2900 gas). I'm not sure how to get 2400.
EIPS/eip-7791.md
Outdated
| The proposed cost of this opcode is similar to the recently proposed `PAY` opcode, but changing the base cost from `9000` to `2400`. That is: | ||
|
|
||
| - The base cost of this opcode is `2400`. This is priced so that invoking `GAS2ETH` on a cold account costs the same as a cold `SSTORE`. | ||
| - If `addr` is not the zero address, the [EIP-2929](./eip-2929.md) account access costs for `addr` (but NOT the current account) are also incurred: 100 gas for a warm account, 2600 gas for a cold account, and 25000 gas for a new account. |
There was a problem hiding this comment.
What does the zero address have to do with this? Does this change some behavior of this opcode?
There was a problem hiding this comment.
that must be a mistake that slipped in over the course of revisions, will fix
|
This seems like a great idea, but I'm nervous about people abusing this. Why would I, as a protocol developer, ever us |
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: