Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store and display contract version #786

Open
tessr opened this issue Dec 12, 2024 · 0 comments
Open

store and display contract version #786

tessr opened this issue Dec 12, 2024 · 0 comments

Comments

@tessr
Copy link
Contributor

tessr commented Dec 12, 2024

At the moment, we check the contract versions for chains by querying their RPC endpoint, and we the contract version checks return TRUE if gov-approved and FALSE otherwise.

However, we don't actually persist or display the version number. This is a detail that the Growth team would like to add to the upcoming SCR frontend, and though they’ve agreed to drop the requirement for the v0, it would be great to have this available for a future iteration of the SCR frontend.

This may also prove useful when doing things like confirming which chains are actually at Stage 1 (see #332).

Example in chainList.json:

  {
    "name": "OP Mainnet",
    "identifier": "mainnet/op",
    "chainId": 10,
    "rpc": [
      "https://mainnet.optimism.io"
    ],
    "explorers": [
      "https://explorer.optimism.io"
    ],
    "superchainLevel": 1,
    "stage": 1,
    "dataAvailabilityType": "eth-da",
    "parent": {
      "type": "L2",
      "chain": "mainnet"
    }
  },

Example in a chain config file:

name = "OP Mainnet"
chain_id = 10
public_rpc = "https://mainnet.optimism.io"
sequencer_rpc = "https://mainnet-sequencer.optimism.io"
explorer = "https://explorer.optimism.io"
superchain_level = 1
stage = 1
superchain_time = 0 # Missing hardfork times are inherited from superchain.toml
batch_inbox_addr = "0xFF00000000000000000000000000000000000010"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant