You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of AssertEVMReverts constructs only memProof without building threadWitness, leading to incomplete data for the entire step. For instance, the TestEVMFaulttest using AssertEVMReverts aims to test for an invalid instruction error in the EVM (MIPS), but the actual error triggered in the EVM is a check that there is enough calldata or invalid thread witness due to incorrect construction of data. This error went undetected because AssertEVMReverts does not verify the actual revert reason.
To address this issue, I propose a two-step fix:
Modify AssertEVMReverts to correctly construct data related to threadWitness.
Add a parameter(expectedReason) to AssertEVMReverts to enable verification of the specific EVM revert information and update the tests that use AssertEVMReverts.
This fix will be implemented across two separate PRs.
The text was updated successfully, but these errors were encountered:
The current implementation of
AssertEVMReverts
constructs onlymemProof
without buildingthreadWitness
, leading to incomplete data for the entire step. For instance, theTestEVMFault
test usingAssertEVMReverts
aims to test for aninvalid instruction
error in the EVM (MIPS), but the actual error triggered in the EVM is acheck that there is enough calldata
orinvalid thread witness
due to incorrect construction of data. This error went undetected becauseAssertEVMReverts
does not verify the actual revert reason.To address this issue, I propose a two-step fix:
AssertEVMReverts
to correctly construct data related tothreadWitness
.expectedReason
) toAssertEVMReverts
to enable verification of the specific EVM revert information and update the tests that useAssertEVMReverts
.This fix will be implemented across two separate PRs.
The text was updated successfully, but these errors were encountered: