Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-monitorism withdrawals, fault, and faultproof_withdrawals should check for min/max OptimismContract version compatibility #91

Open
raffaele-oplabs opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@raffaele-oplabs
Copy link
Contributor

Is your feature request related to a problem? Please describe.

At the moment op-monitorism withdrawals, fault, and faultproof_withdrawals do not check the version of OptimismPortal contract version.
withdrawals, fault are only compatible with pre-faultproof system, while faultproof_withdrawals is only compatible with faultproof.
This would resolve in errors in monitoring if the monitoring is pointing to a chain with the wrong support.
We should have an initial check with compatible version of OptimismPortal necessary for the monitor to work correctly.

Describe the solution you'd like

Before monitor start the OptimismPortal version should be checked for compatibility and only run if the contract is compatible with the monitor, or give a warning before start if not compatible.

Describe alternatives you've considered

Additional context

@raffaele-oplabs raffaele-oplabs added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant