Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ignored mypy type check errors #10

Open
valefar-on-discord opened this issue Apr 16, 2024 · 2 comments
Open

Resolve ignored mypy type check errors #10

valefar-on-discord opened this issue Apr 16, 2024 · 2 comments

Comments

@valefar-on-discord
Copy link
Collaborator

valefar-on-discord commented Apr 16, 2024

There are a number of mypy type checking errors that are a result from integration with https://github.com/ethereum/py-ssz/tree/main

I spent some time trying to resolve these but it felt like fighting a hydra. At this point they are ignored with either
# type: ignore[no-untyped-call], # type: ignore[no-untyped-call], or # type: ignore[attr-defined]

Here is the current list of errors:

staking_deposit/utils/ssz.py:42: error: Call to untyped function "ForkData" in typed context  [no-untyped-call]
staking_deposit/utils/ssz.py:86: error: Call to untyped function "SigningData" in typed context  [no-untyped-call]
staking_deposit/credentials.py:118: error: Call to untyped function "DepositMessage" in typed context  [no-untyped-call]
staking_deposit/credentials.py:128: error: Call to untyped function "DepositData" in typed context  [no-untyped-call]
staking_deposit/credentials.py:129: error: Call to untyped function "as_dict" in typed context  [no-untyped-call]
staking_deposit/credentials.py:141: error: Call to untyped function "as_dict" in typed context  [no-untyped-call]
staking_deposit/credentials.py:168: error: Call to untyped function "BLSToExecutionChange" in typed context  [no-untyped-call]
staking_deposit/credentials.py:180: error: Call to untyped function "SignedBLSToExecutionChange" in typed context  [no-untyped-call]
staking_deposit/credentials.py:189: error: "SignedBLSToExecutionChange" has no attribute "message"  [attr-defined]
staking_deposit/credentials.py:190: error: "SignedBLSToExecutionChange" has no attribute "message"  [attr-defined]
staking_deposit/credentials.py:191: error: "SignedBLSToExecutionChange" has no attribute "message"  [attr-defined]
staking_deposit/credentials.py:194: error: "SignedBLSToExecutionChange" has no attribute "signature"  [attr-defined]
staking_deposit/utils/validation.py:92: error: Call to untyped function "DepositMessage" in typed context  [no-untyped-call]
staking_deposit/utils/validation.py:99: error: Call to untyped function "DepositData" in typed context  [no-untyped-call]
staking_deposit/utils/validation.py:192: error: Call to untyped function "BLSToExecutionChange" in typed context  [no-untyped-call]
@valefar-on-discord
Copy link
Collaborator Author

ethereum/py-ssz#8

@yorickdowne
Copy link

yorickdowne commented Aug 26, 2024

pallets/click#2626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants