backwards compatibility for file:///abs-path #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpintarelli
force-pushed
the
file-prefix
branch
from
a300ef4
to
327fca0
Compare
bcumming
approved these changes
May 31, 2024
bcumming
pushed a commit
that referenced
this pull request
May 31, 2024
There was another instance of `file://` in the code, the plugin exported the image path using `file://` prefix. Causing subsequent srun to fail. This has been fixed already #44. The current PR removes the inconsistent setting of UENV_MOUNT_LIST. `squashfs-mount` omits `file://`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file://to be in image pathUENV_MOUNT_LIST->srun --uenv=''andsrun --uenv=',,,'are now accepted too0.8.0 -> 0.8.1, or should it be0.9.0since--uenvaccepts empty arguments?