Skip to content

Commit

Permalink
Merge pull request #1 from eth-cscs/v0.4.0
Browse files Browse the repository at this point in the history
Make reloader optional and add single-user port to values
  • Loading branch information
rsarm authored May 29, 2024
2 parents 277edfd + 9449787 commit 770a1a0
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 14 deletions.
12 changes: 6 additions & 6 deletions chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ apiVersion: v2
name: f7t4jhub
description: A Helm chart to Deploy JupyterHub with the FirecREST Spawner
type: application
version: 0.3.0
version: 0.4.0
appVersion: "4.1.5"
dependencies:
- name: f7t4jhub
version: 0.3.0
version: 0.4.0
repository: "file://./f7t4jhub"
# Optional dependencies used at CSCS
# - name: reloader
# version: v1.0.51
# repository: https://stakater.github.io/stakater-charts
- name: reloader
version: v1.0.51
repository: https://stakater.github.io/stakater-charts
condition: reloader.reloader.enabled
2 changes: 1 addition & 1 deletion chart/f7t4jhub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: f7t4jhub
description: A Helm chart to Deploy JupyterHub with the FirecREST Spawner
type: application
version: 0.3.0
version: 0.4.0
appVersion: "4.1.5"
2 changes: 1 addition & 1 deletion chart/f7t4jhub/files/jupyterhub-config.py
Original file line number Diff line number Diff line change
Expand Up @@ -1362,7 +1362,7 @@ async def refresh_user(self, user, handler=None):
#
# New in version 0.7.
# Default: 0
c.Spawner.port = 57001
c.Spawner.port = {{ .Values.config.spawner.port }}

## An optional hook function that you can implement to do work after the spawner
# stops.
Expand Down
23 changes: 17 additions & 6 deletions chart/values.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# reloader:
# reloader:
# watchGlobally: false
# isArgoRollouts: true
# serviceAccount:
# create: false
reloader:
reloader:
# Set to true to enable the reloader for automatically restarting pods on ConfigMap/Secret changes.
enabled: false

# If true, the reloader will watch ConfigMaps and Secrets in all namespaces, not just its own.
watchGlobally: false

# Set to true if using Argo Rollouts for managing deployments, which may require specific handling.
isArgoRollouts: true

serviceAccount:
# Set to true to create a new service account for the reloader. If false, it will use an existing one.
create: false

f7t4jhub:
setup:
Expand Down Expand Up @@ -82,6 +90,9 @@ f7t4jhub:
# Host for the spawner (replace with your own host)
host: 'dom'

# Port for the single-user server. Set to 0 to use random port
port: 57001

# Node name template (replace with your own node name template)
nodeNameTemplate: '{}.example.com'

Expand Down

0 comments on commit 770a1a0

Please sign in to comment.