Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when canceling "delete report" action #33

Open
michellutz opened this issue Aug 28, 2018 · 2 comments
Open

Problem when canceling "delete report" action #33

michellutz opened this issue Aug 28, 2018 · 2 comments
Labels
? Unknown status or information missing in the EIP (temp. label)

Comments

@michellutz
Copy link

Background and Motivation

When you click on "Delete report" button, a confirmation window appear. If you click on "Cancel button" you return to the reports view page. However, the url doesn't change, so if you click again in "delete report" nothing happens.

Proposed change

When you click on cancel button, the url should change to base_url/etf-webapp/#test-reports.

Alternatives

Fix the url redirection in test-reports.html.

Funding

TBD

@michellutz michellutz added the EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. label Aug 28, 2018
@jonherrmann
Copy link
Contributor

@michellutz this is not the expected behaviour of ETF. I would suggest closing this issue as it might be either a configuration problem or a bug.

The problem could be related to this question / issue:
etf-validator/etf-webapp#162

@jenriquesoriano
Copy link

After pressing the cancel button, the last parameter should be removed e.g. the id of the test run, so the delete button doesn't considered it to be filled and may prompt again.

This is considered a bug, so an issue will be created in the etf-webapp repository.

@michellutz michellutz removed the EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. label Sep 26, 2018
@jonherrmann jonherrmann added the ? Unknown status or information missing in the EIP (temp. label) label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? Unknown status or information missing in the EIP (temp. label)
Projects
None yet
Development

No branches or pull requests

3 participants