This repository has been archived by the owner on Feb 27, 2021. It is now read-only.
Fix block pagination for tx on Address page #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shane <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Shane <[email protected]>
…regeth fix: update service runner core-geth
…sbranch fix(editorconfig): set pulltagsbranch to empty string
fix: update coregeth to 1.11.16
feat: add gas price average min max
fix: update service runner client + eth client + core-geth
fix: handle bigint with maxBy and minBy
The expression took "0 - 99" as the last item of the oneline if-else, which caused that the from and to values were both = blockNum. This made the pagination to show only one block, allowing only to move in steps of 100 blocks (missing lots of blocks in the middle)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression took
0 - 99as the last item of the onelineif-else, which caused that thefromandtovalues were both= blockNum. This made the pagination to show only one block, while it allowed only to move in steps of 100 blocks (missing lots of blocks in the middle).Adding parentheses to limit the last item of the
if-elsefixes this problem.Fixes #513