EVMC v10 #507
Draft
EVMC v10 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowsbits
force-pushed
the
evmc-v10
branch
2 times, most recently
from
7707886
to
2a9508c
Compare
This was referenced Nov 11, 2022
* core: replace noarg fmt.Errorf with errors.New Signed-off-by: jsvisa <[email protected]> * console: replace noarg fmt.Errorf with errors.New Signed-off-by: jsvisa <[email protected]> * core: go autoimport Signed-off-by: jsvisa <[email protected]> * core: dry Signed-off-by: jsvisa <[email protected]> --------- Signed-off-by: jsvisa <[email protected]>
* accounts: replace noarg fmt.Errorf with errors.New Signed-off-by: jsvisa <[email protected]> * accounts: go autoimport Signed-off-by: jsvisa <[email protected]> --------- Signed-off-by: jsvisa <[email protected]>
This change implements async log retrievals via feeding logs in channels, instead of returning slices. This is a first step to implement #15063. --------- Signed-off-by: jsvisa <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
RPC methods `eth_getHeaderBy*` returned a size value which was meant for internal processes. Please instead use `size` field returned by `eth_getBlockBy*` if you're interested in the RLP encoded storage size of the block. Signed-off-by: jsvisa <[email protected]>
This change splits up the multiple API functions / namespaces currently defined in the eth package into different per-namespace files.
Signed-off-by: jsvisa <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
eth: make StorageRangeAt take a block hash or number Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
This is a minor optimization/refactoring of Feed. --------- Co-authored-by: Felix Lange <[email protected]>
…mplementation (#27310) Deserialize hex keys early to shortcut on invalid input, and re-use the account storageTrie for each proof for each proof in the account, preventing repeated deep-copying of the trie. Closes #27308 -------- Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]>
Drop the notions of uncles, and disables activities while syncing - Disable activities (e.g. generate pending state) while node is syncing, - Disable empty block submission (but empty block is still kept for payload building), - Drop uncle notion since (ethash is already deprecated)
go.mod:golang upgrade
* p2p/discover: remove ReadRandomNodes Even though it's public, this method is not callable by code outside of package p2p/discover because one can't get a valid instance of Table. * p2p/discover: add Table.Nodes * p2p/discover: make Table settings configurable In unit tests and externally developed cmd/devp2p test runs, it can be useful to tune the timer intervals used by Table.
Continuing with a series of PRs to make the Trie interface more generic, this PR moves the RLP encoding of storage slots inside the StateTrie and light.Trie implementations, as other types of tries don't use RLP.
This changes the journal logic to mark the state object dirty immediately when it is reset. We're mostly adding this change to appease the fuzzer. Marking it dirty immediately makes no difference in practice because accounts will always be modified by EVM right after creation.
Date: 2023-08-28 16:40:02-06:00 Signed-off-by: meows <[email protected]>
…hain Date: 2023-08-28 16:43:19-06:00 Signed-off-by: meows <[email protected]>
Date: 2023-08-28 16:44:06-06:00 Signed-off-by: meows <[email protected]>
Date: 2023-08-28 16:57:03-06:00 Signed-off-by: meows <[email protected]>
…st be constant Date: 2023-08-28 17:01:19-06:00 Signed-off-by: meows <[email protected]>
Date: 2023-08-28 17:02:44-06:00 Signed-off-by: meows <[email protected]>
…undefined: params.BlobTxBytesPerFieldElement core/txpool/blobpool/evictheap_test.go:189:65: undefined: params.BlobTxFieldElementsPerBlob core/txpool/blobpool/evictheap_test.go:249:29: undefined: params.BlobTxBytesPerFieldElement core/txpool/blobpool/evictheap_test.go:249:65: undefined: params.BlobTxFieldElementsPerBlob (typecheck) Date: 2023-08-28 17:03:50-06:00 Signed-off-by: meows <[email protected]>
…*EVMInterpreter value in argument to opBlobHash: need type assertion Date: 2023-08-28 17:05:21-06:00 Signed-off-by: meows <[email protected]>
Date: 2023-08-28 17:07:32-06:00 Signed-off-by: meows <[email protected]>
This commit fixes the replacement of clique with catalyst for dev mode on core-geth based on ea78280 . It still allows use of `—dev.pow`
CI tests were failing because the Cancun suite was not skipped. Core-Geth still only supports EVMCv7, so all forks thereafter need to be skipped. AFAIK an upgrade to EVMCv10 should catch up to compatibility for these later forks. Date: 2023-08-29 09:55:26-06:00 Signed-off-by: meows <[email protected]>
ziogaschr
reviewed
Aug 30, 2023
| return db.SelfDestruct(addr) | ||
| db.SelfDestruct(addr) | ||
| // TODO (ziogaschr): check what to return | ||
| return true |
There was a problem hiding this comment.
@meowsbits what do you think of this?
I was thinking to check if the address exists after the SelfDestruct and return it. Though we have to further test on how this works.
Applies logic from c7674bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #506.
Commit history assumes and includes #505.