Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-12-09] Manual Dependency Bump #19048

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Conversation

This commit will bump dependency
- golang.org/x/crypto from 0.29.0 to 0.31.0
- golang.org/x/sys from 0.27.0 to 0.28.0
- golang.org/x/text from 0.20.0 to 0.21.0

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency golang.org/x/net from 0.31.0 to 0.32.0

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency google.golang.org/grpc from 1.68.0 to 1.68.1

Signed-off-by: ArkaSaha30 <[email protected]>
….3.16

This commit will bump dependency github.com/alexfalkowski/gocovmerge from 1.3.14 to 1.3.16

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency github.com/prometheus/common from 0.60.1 to 0.61.0

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency github.com/golangci/golangci-lint from 1.61.0 to 1.62.2

Signed-off-by: ArkaSaha30 <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (f03dee9) to head (3262da4).
Report is 13 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19048      +/-   ##
==========================================
+ Coverage   68.73%   68.78%   +0.05%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24486    24505      +19     
+ Misses       9702     9685      -17     
+ Partials     1435     1433       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03dee9...3262da4. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Dec 12, 2024

Thanks for the pull request, @ArkaSaha30. Should we split commit 2c7504f into three to have explicit commits per dependency?

@ahrtr
Copy link
Member

ahrtr commented Dec 12, 2024

Thanks for the pull request, @ArkaSaha30. Should we split commit 2c7504f into three to have explicit commits per dependency?

I agree that getting them included in separate commits is a little better, It isn't a big problem to me, since the three dependencies are under golang.org/x.

- golang.org/x/crypto from 0.29.0 to 0.31.0
- golang.org/x/sys from 0.27.0 to 0.28.0
- golang.org/x/text from 0.20.0 to 0.21.0

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 026bbec into etcd-io:main Dec 13, 2024
41 checks passed
@ArkaSaha30
Copy link
Contributor Author

ArkaSaha30 commented Dec 13, 2024

Thanks for the pull request, @ArkaSaha30. Should we split commit 2c7504f into three to have explicit commits per dependency?

I agree that getting them included in separate commits is a little better, It isn't a big problem to me, since the three dependencies are under golang.org/x.


- golang.org/x/crypto from 0.29.0 to 0.31.0

- golang.org/x/sys from 0.27.0 to 0.28.0

- golang.org/x/text from 0.20.0 to 0.21.0

Sure, I'll split the commit into 3 as per the packages 👍

Already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants