-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: consistent way to manage go version #19034
Conversation
Hi @manthanguptaa. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi, @manthanguptaa. Thanks for your pull request. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:
Thanks again! |
cd6a2e9
to
29b1705
Compare
@ivanvc I amended the commit and force pushed it. Let me know if this works |
@manthanguptaa, please squash your two commits into a single one. The DCO is still failing because the first commit has not been signed (ultimately, we want to keep only one for this pull request). You can achieve this by running:
Thanks. |
Signed-off-by: Manthan Gupta <[email protected]>
29b1705
to
1ba4f32
Compare
Thank you @ivanvc for helping me make my first contribution to etcd! This was a TIL moment for me |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #19034 +/- ##
==========================================
- Coverage 68.86% 68.81% -0.06%
==========================================
Files 420 420
Lines 35623 35623
==========================================
- Hits 24532 24513 -19
- Misses 9668 9684 +16
- Partials 1423 1426 +3 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @manthanguptaa, for your first contribution to etcd 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, manthanguptaa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes #17857