Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: consistent way to manage go version #19034

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

manthanguptaa
Copy link
Contributor

@manthanguptaa manthanguptaa commented Dec 10, 2024

This fixes #17857

@k8s-ci-robot
Copy link

Hi @manthanguptaa. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@manthanguptaa manthanguptaa changed the title docs: consistent way to manage go version Documentation: consistent way to manage go version Dec 10, 2024
@manthanguptaa
Copy link
Contributor Author

@jmhbnz @ivanvc requesting your review on this

@ivanvc
Copy link
Member

ivanvc commented Dec 10, 2024

Hi, @manthanguptaa. Thanks for your pull request. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:

git commit --amend --signoff # Fix the signed off trailer
git push --force

Thanks again!

@manthanguptaa manthanguptaa force-pushed the consistent_go_version_doc branch from cd6a2e9 to 29b1705 Compare December 11, 2024 05:38
@manthanguptaa
Copy link
Contributor Author

manthanguptaa commented Dec 11, 2024

@ivanvc I amended the commit and force pushed it. Let me know if this works

@ivanvc
Copy link
Member

ivanvc commented Dec 11, 2024

@manthanguptaa, please squash your two commits into a single one. The DCO is still failing because the first commit has not been signed (ultimately, we want to keep only one for this pull request). You can achieve this by running:

git reset --soft HEAD^
git commit --amend --signoff -m "docs: consistent way to manage go version"
git push --force

Thanks.

@manthanguptaa manthanguptaa force-pushed the consistent_go_version_doc branch from 29b1705 to 1ba4f32 Compare December 11, 2024 09:09
@manthanguptaa
Copy link
Contributor Author

Thank you @ivanvc for helping me make my first contribution to etcd! This was a TIL moment for me

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (854bdd6) to head (1ba4f32).
Report is 6 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19034      +/-   ##
==========================================
- Coverage   68.86%   68.81%   -0.06%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24532    24513      -19     
- Misses       9668     9684      +16     
- Partials     1423     1426       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854bdd6...1ba4f32. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Dec 11, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @manthanguptaa, for your first contribution to etcd 🎉

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, manthanguptaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit fe14e24 into etcd-io:main Dec 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Setup a consistent way to manage go version
4 participants