fix: use testify instead of t.Fatal or t.Error in client package (part 1)

[mmorel-35]

Description

This uses testify instead of testing for t.Fatal or t.Error calls in client package

Related to #18972

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (39d9cd7) to head (99f99cb).

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18967      +/-   ##
==========================================
- Coverage   68.77%   68.74%   -0.04%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24500    24489      -11     
- Misses       9699     9708       +9     
- Partials     1424     1426       +2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d9cd7...99f99cb. Read the comment docs.

[ahrtr]

/ok-to-test

[ivanvc]

/retest

[ivanvc]

Question, @mmorel-35. How are you planning on splitting these pull requests? I want to understand it so that I can deliver a proper review :)

[mmorel-35]

I'm grouping PR per package/subpackage and priorizing t.Fatal replacement.
I try to limit the number of modification to less than 100 or 200 lines so it stays reviewable

[ivanvc]

Thanks for the work, @mmorel-35.
I did a grep in the client directory from this branch, and it looks like there are only 24 more instances of t.Fatal after your changes. If you add them, the PR will still be less than 200 changed lines.

[ivanvc]

This line seems to come from the gofumpt change, not directly to testify.

[mmorel-35]

Indeed but as golangci-lint is not executed on windows platform it will never be detected in this file. Shall it be keot or reverted here ?

[mmorel-35]

/retest