Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] backport client: call .Endpoints() in dial() in client/v3/client.go instead of accessing cfg.Endpoints directly #16857

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[3.4] backport client: call .Endpoints() in dial() in client/v3/client.go instead of accessing cfg.Endpoints directly #16857

merged 2 commits into from
Nov 1, 2023

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented Oct 31, 2023 •
edited
Loading

@yishuT @chaochn47
client: call .Endpoints() in dial() in client/v3/client.go instead of…
055b6d7 
… accessing cfg.Endpoints directly

https://github.com/etcd-io/etcd/blob/0cdd558361c6bdbbd9e4023558e2f6ece71c18ad/client/v3/client.go#L299 accesses
endpoints without acquiring lock. Fix it to call Endpoints()

Fix etcd-io#13201

Signed-off-by: Chao Chen <[email protected]>
@chaochn47 chaochn47 force-pushed the release-3.4-atomic-endpoints branch from de5cc66 to 055b6d7 Compare October 31, 2023 16:39
@chaochn47
Copy link
Member Author

cc @ahrtr @serathius @jmhbnz

@chaochn47 chaochn47 force-pushed the release-3.4-atomic-endpoints branch from 3561cf3 to 471225d Compare October 31, 2023 16:59
@ahrtr ahrtr mentioned this pull request Oct 31, 2023
Closed
24 tasks
@chaochn47 chaochn47 force-pushed the release-3.4-atomic-endpoints branch from 471225d to 97a6f95 Compare October 31, 2023 17:24
ahrtr
ahrtr approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @chaochn47

@ahrtr ahrtr merged commit 1eb276c into etcd-io:release-3.4 Nov 1, 2023
12 checks passed
@chaochn47 chaochn47 deleted the release-3.4-atomic-endpoints branch November 1, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaochn47 @ahrtr @yishuT