-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GRPC dependency #16591
Update GRPC dependency #16591
Conversation
…ith grpc 1.54.1+ Signed-off-by: Rafael da Fonseca <[email protected]>
target.Endpoint and some other fields are deprecated, URL field is suggested to use instead path is required to be stripped of "/" prefix for naming/resolver to work porperly Signed-off-by: Ramil Mirhasanov <[email protected]> Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
dc26570
to
11e2a74
Compare
Signed-off-by: Rafael da Fonseca <[email protected]>
0d3a9f3
to
29c5bd2
Compare
Signed-off-by: Rafael da Fonseca <[email protected]>
Note that 3.5 has huge difference from the main branch in terms of code structure, so usually it isn't recommended to cherry pick any commits from main. @chaochn47 since you are the original author for bumping grpc in main branch, could you guide/work together the contributor to complete this PR? |
Hey @rsafonseca sorry for the late reply. This PR updates gRPC directly from For example: The following test failure of current PR was caused by
Please back port all gRPC updates and associated tests since main and release-3.5 diverged. I just blamed the change history of root The history from
I would recommend you back port them one by one in ascending order and check if the local test passes or not by following the contributing guide. Let me know when the first PR is out. I will help you complete this and eventually fix #15877. If you prefer DM, I have sent you the invitation to join the kubernetes slack workplace and I am in the #etcd channel. |
In order to use Outlier Detection, release-3.5 should be at least gRPC-go v1.50.0 onward. Working on it.. |
Discussed during etcd triage. I can take a look to confirm this changes are already satisfied with a different PR. |
/assign @moficodes Thank you very much Mofi! |
I can confirm that they are! This was handled in another thread, we can close it :) |
Fixes testing packages compatibility issues with grpc from 1.55.0 onwards
Resolves #15877