Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: bump go.opentelemetry.io/otel from v1.14.0 to v1.15.0 #15810

Closed
wants to merge 1 commit into from

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented May 2, 2023

@chaochn47
Copy link
Member Author

chaochn47 commented May 2, 2023

TLDR, this version bump is a incompatible change. We should ignore this dependabot notification until the gRPC issue is sorted out.

The following is the explanation of etcd build failures

make build 

stderr: # go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig
stderr: /home/chaochn/.gvm/pkgsets/go1.19.7/global/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/otlpconfig/options.go:100:62: undefined: internal.GetUserAgentHeader

FAIL: (code:2):
  % (cd server && 'env' 'CGO_ENABLED=0' 'GO_BUILD_FLAGS= -v -mod=readonly' 'GOOS=linux' 'GOARCH=amd64' 'go' 'build' '-v' '-mod=readonly' '-trimpath' '-installsuffix=cgo' '-ldflags=-X=go.etcd.io/etcd/api/v3/version.GitSHA=6b002478c' '-o=../bin/etcd' '.')
FAIL: etcd_build (GOARCH=amd64)
make: *** [build] Error 2

otlptracegrpc is already stuck in v1.11.2 because its direct dependency on google.golang.org/grpc v1.51.0

func newTracingExporter(ctx context.Context, cfg *Config) (*tracingExporter, error) {
exporter, err := otlptracegrpc.New(ctx,
otlptracegrpc.WithInsecure(),
otlptracegrpc.WithEndpoint(cfg.ExperimentalDistributedTracingAddress),
)

when initializing the exporter from otlptracegrpc v1.11.2 package, the internal.GetUserAgentHeader() is only defined in go.opentelemetry.io/otel v1.14.0.

// New constructs a new Exporter and starts it.
func New(ctx context.Context, opts ...Option) (*otlptrace.Exporter, error) {
	return otlptrace.New(ctx, NewClient(opts...))
}
func newClient(opts ...Option) *client {
	cfg := otlpconfig.NewGRPCConfig(asGRPCOptions(opts)...)
import "go.opentelemetry.io/otel/exporters/otlp/internal"

// NewGRPCConfig returns a new Config with all settings applied from opts and
// any unset setting using the default gRPC config values.
func NewGRPCConfig(opts ...GRPCOption) Config {
	cfg := Config{
		Traces: SignalConfig{
			Endpoint:    fmt.Sprintf("%s:%d", DefaultCollectorHost, DefaultCollectorGRPCPort),
			URLPath:     DefaultTracesPath,
			Compression: NoCompression,
			Timeout:     DefaultTimeout,
		},
		RetryConfig: retry.DefaultConfig,
		DialOptions: []grpc.DialOption{grpc.WithUserAgent(internal.GetUserAgentHeader())},
	}

@chaochn47
Copy link
Member Author

cc @ahrtr I will close the PR and corresponding dependabot one if there is no objection.

I wanted to add this information to dependency management doc but I think it's better to spend time on resolving #15145 firstly.

@ahrtr
Copy link
Member

ahrtr commented May 2, 2023

cc @ahrtr I will close the PR and corresponding dependabot one if there is no objection.

I have no objection. Thank you for the confirmation.

I wanted to add this information to dependency management doc

Please feel free to deliver a PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants