Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests initiated by field selection can be cancelled #1201

Open
kiahna-tucker opened this issue Aug 8, 2024 · 0 comments
Open

Tests initiated by field selection can be cancelled #1201

kiahna-tucker opened this issue Aug 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kiahna-tucker
Copy link
Member

Bug

The poller monitoring a test initiated by field selection can be cancelled when the selected binding changes.

Reproduction Steps

Initializing the field selection table:

  1. Enter the edit workflow for a materialization with two or more bindings.

  2. Change the selected binding in the Source Collections section of the form while the field selection table is still in a loading state.

  3. Observe that the field selection table indefinitely remains in a loading state for all bindings. Inspecting the API calls made in the workflow reveals that the poller responsible for monitoring background test progress was cancelled when the selected binding changed.

Refreshing the field selection table:

  1. Enter the edit workflow for a materialization with at least one binding.

  2. Add a binding to the materialization.

  3. Click the Next CTA.

  4. Click the field selection Refresh button in the Source Collections section of the form.

  5. Change the selected binding while the field selection table is still in a loading state.

  6. Observe that the field selection table indefinitely remains in a loading state for all bindings. Inspecting the API calls made in the workflow reveals that the poller responsible for monitoring test progress was cancelled when the selected binding changed.

Expected

The field selection table should be initialized if the test succeeded in producing a built_spec and validation object. In the event of a failed test, the table should enter an idle state and the error should be handled appropriately. Additionally, the client state should enter an idle state once the test concludes.

Screenshots

Include a screenshot of what you saw when the bug happened.

Desktop

  • OS: Windows
  • Browser: Version 127.0.6533.90

Additional Context

  • All tests are initiated by the top-level field selection component (i.e., FieldSelectionViewer, src/components/editor/Bindings/FieldSelection/index.tsx). This component is unmounted whenever the selected binding changes.
@kiahna-tucker kiahna-tucker added the bug Something isn't working label Aug 8, 2024
@kiahna-tucker kiahna-tucker self-assigned this Aug 8, 2024
@kiahna-tucker kiahna-tucker removed their assignment Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant