Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interface.html] storage cache #3631

Open
bobrippling opened this issue Oct 30, 2024 · 1 comment
Open

[interface.html] storage cache #3631

bobrippling opened this issue Oct 30, 2024 · 1 comment

Comments

@bobrippling
Copy link
Collaborator

@gfwilliams @thyttan I'm thinking of making the file cache used in recorder (#3607) apply to all Utils.readStorage(), so that the health interface would benefit from it - users wouldn't have to wait to re-read the same data if they want to switch between a chart and a table.

I have half a PR but wanted to know, is this a change that'd be accepted?

@gfwilliams
Copy link
Member

I'm not sure...

For instance health data updates every 10 minutes. So maybe someone downloads the current health data then does it again a few minutes later, but then it wouldn't include the newer data? Or what if some other command is sent which updates the file in the mean time, or the user is actually running the app which is updating the file?

I just wonder whether this is fixing a problem that doesn't really exist? I can 100% imagine it makes sense with recorder, but I feel for other apps maybe not so much - I don't think anyone's complained about it and it's not like many of the files are so big they take a long time to get?

I feel like maybe the possibilities for this breaking things/making the app loader unreliable might outweigh the small inconvenience of waiting? What does everyone else think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants