Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the Code Flashing Binaries to Target (RDT-576) #235

Closed
hfudev opened this issue Nov 3, 2023 · 0 comments · Fixed by #236
Closed

Revise the Code Flashing Binaries to Target (RDT-576) #235

hfudev opened this issue Nov 3, 2023 · 0 comments · Fixed by #236
Labels
enhancement New feature or request

Comments

@hfudev
Copy link
Member

hfudev commented Nov 3, 2023

For now we're calling internal esptool functions while flash. Research if we could

  1. get target

    esp: esptool.ESPLoader = esptool.get_default_connected_device(
        ports,
        port=port,
        connect_attempts=3,
        initial_baud=baud,
        chip=esptool_target,
    )
  2. call esptool.main(*args, esp=esp) to use esptool cli functions

Besides, the subprocess call of esptool existing elsewhere could also be replaced by esptool.main

@hfudev hfudev added the enhancement New feature or request label Nov 3, 2023
@github-actions github-actions bot changed the title Revise the Code Flashing Binaries to Target Revise the Code Flashing Binaries to Target (RDT-576) Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant