Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[idf] replace threads in MultiDevCaseTester (RDT-317) #162

Closed
alekseiapa opened this issue Nov 23, 2022 · 2 comments · Fixed by #223
Closed

[idf] replace threads in MultiDevCaseTester (RDT-317) #162

alekseiapa opened this issue Nov 23, 2022 · 2 comments · Fixed by #223
Labels
enhancement New feature or request refactor
Milestone
1.x

Comments

@alekseiapa
Copy link
Collaborator

Currently we use threads for the serial output redirection purposes. Python Global Interpreter Lock might cause the block of the threads. In order to avoid block we should reduce their amount
@github-actions github-actions bot changed the title replace threads in MultiDevCaseTester replace threads in MultiDevCaseTester (RDT-317) Nov 23, 2022
@hfudev hfudev mentioned this issue Nov 25, 2022
Merged
@hfudev hfudev added this to the 1.x milestone Nov 29, 2022
@hfudev
Copy link
Member

hfudev commented Dec 30, 2022 •
edited
Loading

Besides, the "fake test case" issue with ESP-IDF unity multi device test cases still exists. The single board issue has been fixed in #166

@hfudev hfudev changed the title replace threads in MultiDevCaseTester (RDT-317) [idf] replace threads in MultiDevCaseTester (RDT-317) Dec 30, 2022
@hfudev hfudev added the enhancement New feature or request label Dec 30, 2022
@hfudev hfudev assigned hfudev and unassigned hfudev Jul 19, 2023
@hfudev
Copy link
Member

hfudev commented Jul 20, 2023

@horw PTAL. Besides, some modifications are done in https://github.com/espressif/esp-idf/blob/master/tools/ci/idf_unity_tester.py#L180. Please pull those changes in as well.

Our future plan is to replace the code in esp-idf with this one.

@horw horw mentioned this issue Jul 26, 2023
Merged
@horw horw mentioned this issue Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
1.x
2 participants
@hfudev @alekseiapa