Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap usage stats with defmt #2619

Merged
merged 15 commits into from
Nov 28, 2024
Merged

Conversation

okhsunrog
Copy link
Contributor

@okhsunrog okhsunrog commented Nov 27, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

This is based on #2137 with defmt::Format trait properly implemented and minor changes in format of heap stats, tested with defmt on esp32-c3

qa-test/src/bin/psram_quad.rs Outdated Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Much appreciated.

LGTM!

Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! 😉❤️

Changes look good to me overall, just a handful of docs-related comments. As soon as it's answered/ignored - I'll approve it!

esp-alloc/Cargo.toml Outdated Show resolved Hide resolved
esp-alloc/src/lib.rs Outdated Show resolved Hide resolved
esp-alloc/src/lib.rs Outdated Show resolved Hide resolved
esp-alloc/src/lib.rs Outdated Show resolved Hide resolved
okhsunrog and others added 4 commits November 28, 2024 15:13
Co-authored-by: Kirill Mikhailov <[email protected]>
Co-authored-by: Kirill Mikhailov <[email protected]>
@okhsunrog
Copy link
Contributor Author

okhsunrog commented Nov 28, 2024

@playfulFence thanks for your comments, it's indeed cleaner this way.
Waiting for an approval :D

@playfulFence
Copy link
Contributor

Hahaha 🤣
image
I appreciate the sense of humour!
As soon as CI passes - we'll merge it, thanks again ❤️

@playfulFence
Copy link
Contributor

playfulFence commented Nov 28, 2024

image image

Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

edit: oops

@playfulFence playfulFence added this pull request to the merge queue Nov 28, 2024
Merged via the queue into esp-rs:main with commit 2d87bb0 Nov 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants