-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heap usage stats with defmt #2619
Conversation
… extra computation. - Introduce the `internal-heap-stats` feature for `esp-alloc`. - Add `esp_alloc::get_info!()` to `psram_quad` example to show usage and ensure coverage of the feature in tests.
…ing `HEAP.stats()`
Co-authored-by: Scott Mabin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! Much appreciated.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо! 😉❤️
Changes look good to me overall, just a handful of docs-related comments. As soon as it's answered/ignored - I'll approve it!
Co-authored-by: Kirill Mikhailov <[email protected]>
Co-authored-by: Kirill Mikhailov <[email protected]>
Co-authored-by: Kirill Mikhailov <[email protected]>
Co-authored-by: Kirill Mikhailov <[email protected]>
@playfulFence thanks for your comments, it's indeed cleaner this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
edit: oops
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
This is based on #2137 with defmt::Format trait properly implemented and minor changes in format of heap stats, tested with defmt on esp32-c3