Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passive scanning #57

Open
umgefahren opened this issue Oct 23, 2023 · 7 comments
Open

Add support for passive scanning #57

umgefahren opened this issue Oct 23, 2023 · 7 comments

Comments

@umgefahren
Copy link

My application requires passive wifi scanning wich is not possible through the trait. My suggestion would be to add some config for the wifi scanning. I also consider it suboptimal that a Vec is returned from the scan method. Why not an iterator?

@ivmarkov
Copy link
Collaborator

ivmarkov commented Oct 23, 2023

My application requires passive wifi scanning wich is not possible through the trait. My suggestion would be to add some config for the wifi scanning.

This project is largely driven by community contributions, so the fastest way to get what you want is to work on a PR.

I also consider it suboptimal that a Vec is returned from the scan method. Why not an iterator?

Because the underlying ESP IDF driver does not allow that.

@ivmarkov
Copy link
Collaborator

ivmarkov commented Oct 23, 2023

By the way - you've opened this issue in the wrong project. Please move it to esp-idf-svc and close this one.

@ivmarkov
Copy link
Collaborator

In fact, passive scanning is already supported in esp-idf-svc. It is only not exposed in the Wifi trait, that's all.

@umgefahren
Copy link
Author

But in order to be exposed in the WIFI trait there needs to be a trait method, right?

I will draft up a PR for that as soon as possible.

@ivmarkov
Copy link
Collaborator

Why do you want to go for this via the Wifi trait? Are you trying to somehow keep your code abstract, so that it works on something else besides Espressif chips?

If not, then this effort is not worth it.

@umgefahren
Copy link
Author

Yes and I generally prefer the high level abstractions. I thought it might be a good idea since it's supported by a lot of wifi drivers. It would also enable to pass detailed options on how to perform the scanning.

@ivmarkov
Copy link
Collaborator

Well, fine then. Please work on a PR, and then we can discuss once we have your suggested changes.

In any case, getting your feet wet with the esp-idf-* echosystem and trying passive scan by directly calling the EspWifi structure is highly advisable before trying a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants