You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that at least some of the xfails we have in ESMPy testing are tests that exceptions are caught appropriately - e.g., test_interfaceint2 in test_cbindings.py:
(1) The test results would be cleaner: I think of xfails as being tests that are currently not working right that we want to fix eventually, and a completely clean test result wouldn't have any xfails.
(2) We could ensure that the correct exception is being raised.
The text was updated successfully, but these errors were encountered:
I noticed that at least some of the xfails we have in ESMPy testing are tests that exceptions are caught appropriately - e.g., test_interfaceint2 in test_cbindings.py:
esmf/src/addon/esmpy/src/esmpy/test/test_cbindings.py
Lines 37 to 45 in 7e6ffb3
I haven't looked closely, but I think these could / should be converted to expected exception handling - e.g., see https://pytest-with-eric.com/introduction/pytest-assert-exception/
Benefits would be:
(1) The test results would be cleaner: I think of xfails as being tests that are currently not working right that we want to fix eventually, and a completely clean test result wouldn't have any xfails.
(2) We could ensure that the correct exception is being raised.
The text was updated successfully, but these errors were encountered: