-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: [playground]alert item add Disabled button. #548
Comments
Thanks for submitting this. While I understand what you're going for, the point of filing an issue is to provide details as to what change you'd like to make and why you'd like to make it. One sentence really isn't enough for us to evaluate. |
Seems reasonable to me, although the button should be labeled "Disable" or maybe "Ignore"? And not sure if we should just remove it from the configuration or set to "off". Would like some thoughts from @eslint/eslint-team |
I think the label should be |
If we'd add a "Config" button that would scroll to the rule's config, as proposed in #550, then we might not need this button as the user can there easily remove it or set it to |
Should we also disable the rule inline with |
I think it makes more sense to implement #550, this would solve both issues. See #550 (comment) |
I think a "Disable" button is a much better user experience if your goal is to disable a rule. Clicking on "config" and then needing to shift focus, then edit the config, then go back to the editor is a lot of steps. |
I too feel the same disable button is better.
|
I think it depends on what use case we want to focus on. If we think that people disabling a rule is the more common case, then it makes sense to have a "Disable" button. If we think that people modifying the rule's config is more common and that disabling is a less common case, then just having a "Config" button makes sense. |
What problem do you want to solve?
we can Disabled an rule quickly.
What do you think is the correct solution?
add Disabled button.
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: