Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: [playground]alert item add Disabled button. #548

Closed
1 task done
zhangenming opened this issue Apr 9, 2024 · 10 comments · Fixed by #546
Closed
1 task done

Suggestion: [playground]alert item add Disabled button. #548

zhangenming opened this issue Apr 9, 2024 · 10 comments · Fixed by #546
Labels
accepted enhancement New feature or request

Comments

@zhangenming
Copy link
Contributor

What problem do you want to solve?

we can Disabled an rule quickly.

What do you think is the correct solution?

add Disabled button.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@zhangenming zhangenming added the enhancement New feature or request label Apr 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 9, 2024
@zhangenming zhangenming changed the title Suggestion: alert item add Disabled button. Suggestion: [playground]alert item add Disabled button. Apr 9, 2024
@nzakas
Copy link
Member

nzakas commented Apr 10, 2024

Thanks for submitting this. While I understand what you're going for, the point of filing an issue is to provide details as to what change you'd like to make and why you'd like to make it. One sentence really isn't enough for us to evaluate.

@nzakas nzakas moved this from Needs Triage to Triaging in Triage Apr 10, 2024
@zhangenming
Copy link
Contributor Author

zhangenming commented Apr 11, 2024

what change you'd like to make

add a button like this
image

why you'd like to make it.

can quickly remove rules that I know I don't want

@nzakas nzakas moved this from Triaging to Feedback Needed in Triage Apr 11, 2024
@nzakas
Copy link
Member

nzakas commented Apr 11, 2024

Seems reasonable to me, although the button should be labeled "Disable" or maybe "Ignore"?

And not sure if we should just remove it from the configuration or set to "off".

Would like some thoughts from @eslint/eslint-team

@snitin315
Copy link
Contributor

I think the label should be Disable and we should turn it off instead of removing from the config.

@snitin315 snitin315 moved this from Feedback Needed to Ready to Implement in Triage Apr 14, 2024
@snitin315 snitin315 moved this from Ready to Implement to Implementing in Triage Apr 14, 2024
@mdjermanovic
Copy link
Member

If we'd add a "Config" button that would scroll to the rule's config, as proposed in #550, then we might not need this button as the user can there easily remove it or set it to "off", whichever they prefer.

@harish-sethuraman
Copy link
Member

Should we also disable the rule inline with eslint-disable comment or should we rather remove it from the list of selected rules?

@snitin315
Copy link
Contributor

snitin315 commented Jun 30, 2024

If we'd add a "Config" button that would scroll to the rule's config, as proposed in #550, then we might not need this button as the user can there easily remove it or set it to "off", whichever they prefer.

I think it makes more sense to implement #550, this would solve both issues. See #550 (comment)

@nzakas
Copy link
Member

nzakas commented Jul 1, 2024

I think a "Disable" button is a much better user experience if your goal is to disable a rule. Clicking on "config" and then needing to shift focus, then edit the config, then go back to the editor is a lot of steps.

@amareshsm
Copy link
Member

I too feel the same disable button is better.

I think a "Disable" button is a much better user experience if your goal is to disable a rule. Clicking on "config" and then needing to shift focus, then edit the config, then go back to the editor is a lot of steps.

@nzakas
Copy link
Member

nzakas commented Jul 2, 2024

I think it depends on what use case we want to focus on. If we think that people disabling a rule is the more common case, then it makes sense to have a "Disable" button. If we think that people modifying the rule's config is more common and that disabling is a less common case, then just having a "Config" button makes sense.

@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants