Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errata information #46

Open
nocollier opened this issue Apr 25, 2024 · 2 comments
Open

Add errata information #46

nocollier opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nocollier
Copy link
Member

There is an API to query the ES-Doc errata service:

https://test-errata.es-doc.org/static/index.html
https://ipsl.gitbook.io/esgf-errata-service/errata-service-api#simple-pid-search

The simple PID search allows us to ask for errata by dataset_id. First I need to learn to query the errata service and include a column to the catalog dataframe that indicates an issue exists.

Exactly when that functionality is called is less clear to me at this time:

  • We could query at the end of cat.search() and add a boolean/reference to each row of the dataframe. This could be slow and the user may be in the initial phase of their search and not yet care about errata.
  • It could be added to the dataframe asynchronously, so the user can continue to search/view results while this information is added.
  • We could have a function that will query errata and add it on demand, perhaps cat.check_errata()? This probably the safest option to start.

@AtefBN

@nocollier
Copy link
Member Author

nocollier commented Apr 25, 2024

@pchengi Will ping you when this gets done. He is thinking about it from the node manager's point of view.

@AtefBN
Copy link

AtefBN commented Apr 25, 2024

FYI, the https://test-errata.es-doc.org/ domain is behind on versions and hosted under a different infrastructure. I should either retire it or update it, but in the meantime feel free to use the main domain even for tests https://errata.ipsl.fr/static/index.html it should handle the load just fine (fingers crossed)

@nocollier nocollier added the enhancement New feature or request label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants