Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Required" parameters on galaxy frontend #4

Open
andriineronov opened this issue Jan 10, 2025 · 2 comments
Open

"Required" parameters on galaxy frontend #4

andriineronov opened this issue Jan 10, 2025 · 2 comments
Assignees

Comments

@andriineronov
Copy link

I made a galaxy tool for the synchrotron-inverse Compton project, and there there is a possibility to either define the electron spectrum with a formula, or input it as a file. In Galaxy, it thinks that the "input as a file" is a "required" parameter, but it should be "either-or"

image
@dsavchenko
Copy link

It's not expressed in annotations that this parameter is optional. In fact, your default value contradicts annotation.

There is oda:optional term to designate optional parameters, in this case the value "not set" should be None.

We don't support optional parameters in galaxy tools yet (files or not), but I imagine it's not a complicated change.

In MMODA, we also lack support of optional parameters on the frontend level.
Somehow file inputs are intrinsically optional (but I'm not sure, I let @burnout87 comment on this). If so, that could be misleading depending on the default value of the parameter (what if it refers to local file by default but user sets nothing in frontend? Will default value be used? That's completely wrong if true.).

@burnout87
Copy link

In MMODA, we also lack support of optional parameters on the frontend level. Somehow file inputs are intrinsically optional (but I'm not sure, I let @burnout87 comment on this). If so, that could be misleading depending on the default value of the parameter (what if it refers to local file by default but user sets nothing in frontend? Will default value be used? That's completely wrong if true.).

On the frontend side, they are optional, in the sense that no default file is selected. But, in theory, in the notebook, it can refer to a file locally available, we cannot exclude it. So, in that case, the local file will be used in the execution. It would be interesting to test this case, I will and will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants