Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display album cover #37

Open
pasikonik opened this issue Mar 3, 2023 · 3 comments
Open

Display album cover #37

pasikonik opened this issue Mar 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pasikonik
Copy link

This extension is great, but I'm missing one functionality. I'm talking about showing an album cover after click on tray or keyboard shortcut (better one).

Do you consider adding this feature?
Media Controls has it, but for me simplicity is important, therefore I chose this extension.
Screenshot from 2023-03-03 11-03-07

I can try to do a Pull Request if you accept the contributions here.

@esenliyim
Copy link
Owner

I've considered this in the past, but decided against it because I thought it goes beyond my goal of creating "a simple label" that's just there.

I'll give it more thought, though. You could fire a PR if you've already implemented it yourself, but otherwise don't bother because I could very well end up rejecting it and wasting your time.

@esenliyim
Copy link
Owner

A small update on this, I'm currently experimenting with an A-B repeat feature, which I've always found is criminally missing from most modern media players. It's gonna be an ugly and imprecise hack at best, but better than nothing I guess.

Anyway, what that means is, if I decide to add it to this extension, it might mean I might start taking it in another direction. Which would in turn mean making it a bit more feature-rich, rather than just a simple label.

@esenliyim esenliyim added the enhancement New feature or request label Oct 10, 2023
@Moon-0xff
Copy link

Hello! I stumbled upon this issue and I figured it's best if I share that we implemented this a year ago for gnome-mpris-label.

The conversation thread is a lot of back-and-forth, but the final changes merged to the main branch are quite small, just check the diff (or the "files changed" tab on github) of the files players.js and extension.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants