Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT use batch_dump_frames.py with -n > 1 #2

Open
escorciav opened this issue Sep 30, 2018 · 1 comment
Open

NOT use batch_dump_frames.py with -n > 1 #2

escorciav opened this issue Sep 30, 2018 · 1 comment

Comments

@escorciav
Copy link
Owner

It seems that FFmpeg is not thread-safe even spawned in different contexts.

  • This might affect other scripts that call FFmpeg such as batch_video_editing.py and video_info.py. However, I have only seen the bug in batch_dump_frames.py.
@escorciav escorciav mentioned this issue Sep 30, 2018
Closed
@escorciav escorciav mentioned this issue Apr 6, 2019
Closed
@escorciav
Copy link
Owner Author

@ soldelli pointed out this explanation as cause. However, it's unclear to me if subprocess is doing something along those lines.

@ dandelin noticed another issue using FFmpeg+joblib. The solution was to use only multiprocessing. However, joblib uses multiprocessing as the default backend 😖

escorciav added a commit that referenced this issue May 19, 2019
@escorciav
[tools] Disable multiprocessing
e2a6f23 
Given that multiple "threads" give not reproducible results with
ffmpeg+multiprocessing (#2), we disable them by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@escorciav