Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM: Pointer values need to be compared for results that are returned as pointers, rather than comparing the pointers themselves (memory addresses). #86

Closed
Yiannis128 opened this issue Oct 3, 2023 · 1 comment
Labels
research This issue isn't being worked on, it is being considered, and researched.

Comments

@Yiannis128
Copy link
Collaborator

Yiannis128 commented Oct 3, 2023

This will be resolved by #87, but we should consider if this behavior should be made default. For example:

int * result_old = function_old(a, b, c);
int * result_new = function_new(a, b, c);

Should the following comparison be kept for pointer return types:

assert(result_old == result_new);

Or should the following result be dynamically used (for pointer types):

assert(*result_old == *result_new);
@Yiannis128 Yiannis128 changed the title Pointer values need to be compared for results that are returned as pointers, rather than comparing the pointers themselves (memory addresses). OCM: Pointer values need to be compared for results that are returned as pointers, rather than comparing the pointers themselves (memory addresses). Oct 3, 2023
@Yiannis128 Yiannis128 added the research This issue isn't being worked on, it is being considered, and researched. label Oct 4, 2023
@Yiannis128
Copy link
Collaborator Author

Handled by #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research This issue isn't being worked on, it is being considered, and researched.
Projects
None yet
Development

No branches or pull requests

1 participant