Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs with no type cause NullPointerException #57

Open
kml27 opened this issue Sep 21, 2018 · 2 comments
Open

inputs with no type cause NullPointerException #57

kml27 opened this issue Sep 21, 2018 · 2 comments
Assignees
Labels
bug Something isn't working ready for testing simple
Milestone

Comments

@kml27
Copy link
Collaborator

kml27 commented Sep 21, 2018

Check for null or empty string and default to "text" per HTML spec.

@kml27 kml27 added this to the rc1 milestone Sep 21, 2018
@kml27 kml27 self-assigned this Sep 21, 2018
@kml27 kml27 modified the milestones: rc1, future Sep 21, 2018
@kml27 kml27 added bug Something isn't working simple labels Sep 21, 2018
kml27 added a commit that referenced this issue Sep 22, 2018
@kml27 kml27 assigned jsibley and unassigned kml27 Sep 24, 2018
@jsibley
Copy link
Collaborator

jsibley commented Sep 26, 2018

Where do we have inputs with no type? And why not just give them a type?

@kml27
Copy link
Collaborator Author

kml27 commented Sep 27, 2018

We currently do assign a type to all inputs, but this prevents it from possibly being an issue later when more time may have passed and would then take more time to resolve. I ran across this when I was testing the typeahead support ( #16 ) implementation option of changing the FNM/ICD10 selects back to <input list="datalist-id">s with <datalist/>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for testing simple
Projects
None yet
Development

No branches or pull requests

2 participants