Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intake form - console error for invalid companion phone number is not focusable when submitting form #48

Open
kml27 opened this issue Sep 19, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@kml27
Copy link
Collaborator

kml27 commented Sep 19, 2018

enter encounter values, enter a string like comp2 in companion phone number, goto section 7, submit

@kml27
Copy link
Collaborator Author

kml27 commented Sep 19, 2018

prevents submission, but provides no obvious reason as to why

@kml27
Copy link
Collaborator Author

kml27 commented Sep 19, 2018

options (mixture of which and/or others may be a solution) include

  • provide a generic check for errors alert in header
  • provide valid and invalid styling so individual elements show their validation state (check or x?)
  • force to tab to show the first of any errors on submission, users should rinse, repeat

please add any other options for discussion

@kml27 kml27 added this to the future milestone Sep 20, 2018
@jsibley
Copy link
Collaborator

jsibley commented Sep 20, 2018

Note that this also happens for the 'Period for medication (days)' field on the 'Treatment' section of the f/u form.

kml27 added a commit to kml27/mental-health-mockup that referenced this issue Sep 20, 2018
@kml27 kml27 reopened this Sep 20, 2018
@kml27 kml27 modified the milestones: future, rc1 Sep 20, 2018
@jsibley
Copy link
Collaborator

jsibley commented Sep 21, 2018

Still not quite there yet. If I enter an invalid value, then click on another tab, I briefly see the pop-up telling me the value is invalid, but it would be easy to miss/dismiss. I think we'll be better served either with immediate validation checking as they're typing in the field or maybe we can put a flag on the tab if any invalid elements are within it?

@jsibley jsibley added bug Something isn't working medium priority and removed ready for testing labels Sep 21, 2018
@kml27
Copy link
Collaborator Author

kml27 commented Sep 24, 2018

60e374f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants