Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed to NodeCG/SponsorLogoChanged? #10

Open
zoton2 opened this issue Apr 22, 2020 · 0 comments
Open

Changes needed to NodeCG/SponsorLogoChanged? #10

zoton2 opened this issue Apr 22, 2020 · 0 comments
Labels
question Further information is requested

Comments

@zoton2
Copy link
Member

zoton2 commented Apr 22, 2020

Right now the message will be sent when the sponsor logo changes on the layouts, which will either supply a logo's details, or nothing if none is currently on display.

There is a length field based on the length specified in the NodeCG dashboard, but it's not accurate for how long the logo has actually been shown, so should it be removed or kept but a note added not to use it to calculate anything that needs exact times?

I'm wondering also if moving all of the logos data into it's own object inside the message might be a good idea, and if the object is not defined you know there is no logo. I would like to also add some other data if needed, for example the checksum for the file (in case the name cannot be found, which sometimes happens when NodeCG first starts up), although not sure if required.

From a discussion on Discord, we are also not sure how/if organisers are using this data and what they may want, so may need to enquire with them too.

Also, in the near future the area on the layouts/logic that handles the sponsor logos may also be used for other items and I am not sure if those will also need logging, and if so we should change the name/routing key for this message.

@zoton2 zoton2 added the question Further information is requested label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant