Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace graphemer to unicode-segmenter/grapheme in the Bluesky app #135

Open
cometkim opened this issue Nov 24, 2024 · 4 comments
Open

Replace graphemer to unicode-segmenter/grapheme in the Bluesky app #135

cometkim opened this issue Nov 24, 2024 · 4 comments
Labels
has pr This issue has a corresponding PR in the target repo needs first contact It is unclear if the maintainer of the repo is open for e18e

Comments

@cometkim
Copy link

Note: Bluesky is an RN app, so they cannot rely on the platform-provided Intl.Segmenter

Manifest & Docs:

Opened PRs:

@ljharb
Copy link

ljharb commented Dec 18, 2024

Why not? RN runs in a webview so they should be able to rely on JS features like Intl just fine.

@cometkim
Copy link
Author

Why not? RN runs in a webview so they should be able to rely on JS features like Intl just fine.

Sure, if they're not using Hermes for native targets

@ljharb
Copy link

ljharb commented Dec 18, 2024

aha, fair.

@cometkim
Copy link
Author

I don't think their social apps or consumers of atproto can rely on Intl.Segmenter, at least yet.

See previous discussions around bluesky-social/atproto#1044

@Fuzzyma Fuzzyma added needs first contact It is unclear if the maintainer of the repo is open for e18e has pr This issue has a corresponding PR in the target repo labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has pr This issue has a corresponding PR in the target repo needs first contact It is unclear if the maintainer of the repo is open for e18e
Projects
None yet
Development

No branches or pull requests

3 participants