Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cpy to node:fs #124

Open
ziebam opened this issue Oct 6, 2024 · 1 comment · May be fixed by semantic-release/github#944
Open

Migrate cpy to node:fs #124

ziebam opened this issue Oct 6, 2024 · 1 comment · May be fixed by semantic-release/github#944
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each

Comments

@ziebam
Copy link

ziebam commented Oct 6, 2024

I noticed it in https://github.com/semantic-release/github/blob/7d64dbbc83496db2fef0a4fb419a554106e226a6/package.json#L45, haven't had the chance to check other projects yet. A few reasons:

  1. node:fs is sufficient for modern Node versions.
  2. cpy pulls in relatively many transitive dependencies, including is-number.
  3. The author himself recommends against using the package.
    image
@Namchee
Copy link

Namchee commented Oct 10, 2024

Note: cpy is only used for devDependencies here

@mcmxcdev mcmxcdev linked a pull request Oct 16, 2024 that will close this issue
Open
@Fuzzyma Fuzzyma added the umbrella issue This issue contains a list of dependents of a package and tracks the progress in each label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: drop cpy dependency in favor of native node:fs functionality mcmxcdev/github
3 participants
@Fuzzyma @ziebam @Namchee