From 2e6150ccc43cbcccf9923463bb2c899e16b8fcd3 Mon Sep 17 00:00:00 2001
From: Kevin Delemme <kevin.delemme@elastic.co>
Date: Mon, 19 Feb 2024 11:51:16 -0500
Subject: [PATCH] fix(slo): Aria labels (#177202)

---
 .../components/slo_edit_form_indicator_section.tsx    | 11 ++++++-----
 .../public/pages/slos/components/slo_context_menu.tsx |  4 +++-
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_indicator_section.tsx b/x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_indicator_section.tsx
index 8db7460014a0b..eff001a751dd3 100644
--- a/x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_indicator_section.tsx
+++ b/x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_indicator_section.tsx
@@ -59,11 +59,7 @@ export function SloEditFormIndicatorSection({ isEditMode }: SloEditFormIndicator
     >
       {!isEditMode && (
         <>
-          <EuiFormRow
-            label={i18n.translate('xpack.observability.slo.sloEdit.definition.sliType', {
-              defaultMessage: 'Choose the SLI type',
-            })}
-          >
+          <EuiFormRow label={indicatorLabel}>
             <Controller
               name="indicator.type"
               control={control}
@@ -74,6 +70,7 @@ export function SloEditFormIndicatorSection({ isEditMode }: SloEditFormIndicator
                   required
                   data-test-subj="sloFormIndicatorTypeSelect"
                   options={SLI_OPTIONS}
+                  aria-label={indicatorLabel}
                 />
               )}
             />
@@ -85,3 +82,7 @@ export function SloEditFormIndicatorSection({ isEditMode }: SloEditFormIndicator
     </EuiPanel>
   );
 }
+
+const indicatorLabel = i18n.translate('xpack.observability.slo.sloEdit.definition.sliType', {
+  defaultMessage: 'Choose the SLI type',
+});
diff --git a/x-pack/plugins/observability/public/pages/slos/components/slo_context_menu.tsx b/x-pack/plugins/observability/public/pages/slos/components/slo_context_menu.tsx
index de03eab18fbb1..a0a133da2f7c6 100644
--- a/x-pack/plugins/observability/public/pages/slos/components/slo_context_menu.tsx
+++ b/x-pack/plugins/observability/public/pages/slos/components/slo_context_menu.tsx
@@ -82,7 +82,7 @@ export function SLOContextMenu({
               <span>{label}</span>
             </EuiTitle>
           </EuiFlexItem>
-          <EuiFlexItem grow={false} data-test-subj="syntheticsOverviewGroupButton">
+          <EuiFlexItem grow={false} data-test-subj="sloOverviewGroupButton">
             <EuiPopover
               id={singleContextMenuPopoverId}
               button={button}
@@ -90,6 +90,7 @@ export function SLOContextMenu({
               closePopover={() => setIsPopoverOpen(false)}
               panelPaddingSize="none"
               anchorPosition="downLeft"
+              aria-label={label}
             >
               <EuiContextMenuPanel size="s" items={items} style={{ minWidth: 160 }} />
             </EuiPopover>
@@ -114,6 +115,7 @@ export function ContextMenuItem({
   return (
     <EuiContextMenuItem
       size="s"
+      aria-label={option.label}
       key={option.value}
       icon={getIconType(option.checked)}
       onClick={() => {