Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider name supplied with mix task not used #10

Open
LostKobrakai opened this issue Nov 4, 2024 · 1 comment
Open

Provider name supplied with mix task not used #10

LostKobrakai opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@LostKobrakai
Copy link

oidcc version

3.2

Erlang version

27

Elixir version

1.17.3

Summary

As documented I used this mix task invokation

mix phx.gen.oidcc \
    MyApp.ConfigProviderName \
    "https://issuer.example.com" \
    "client_id" \
    "client_secret"

Current behavior

MyApp.ConfigProviderName is not used anywhere in the generated code. Instead config is scoped to config :myapp, Oidcc, …, which would "break" once another provider is added.

How to reproduce

Grep the changed files for MyApp.ConfigProviderName after running the mix command

Expected behavior

Scope the worker name as well as config to the provided name.

@LostKobrakai LostKobrakai added the bug Something isn't working label Nov 4, 2024
@maennchen
Copy link
Member

This project & issue will be obsolete once I find the time to finish this PR: erlef/oidcc_plug#23

Keeping it open until then.

@maennchen maennchen self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants