compiler: Improve error messages with jaro_similarity #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For errors that can easily be caused by typos, we now check distances to possible fixes and suggest it if it is close enough. Two example error messages (function baz/1 and variable State are defined): function bar/1 undefined, did you mean baz/1? variable 'Stat' is unbound, did you mean 'State'? Error types that are extended by this change: bad_inline, undefined_nif, bad_nowarn_unused_function, undefined_on_load, undefined_function, undefined_record, undefined_field, unbound_var.
lucioleKi
added
the
testing
CT Test Results 2 files 95 suites 35m 11s ⏱️ For more details on these failures, see this check. Results for commit 88f1d4b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
lucioleKi
added
testing
lucioleKi
added a commit
that referenced
this pull request
Aug 15, 2024
lucioleKi
added a commit
that referenced
this pull request
Aug 15, 2024
* isabell/parsetools/yecc-test-fix: yecc_SUITE: fix errors after PR #8699 jaro similarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For errors that can easily be caused by typos, we now check distances to possible fixes and suggest it if it is close enough.
Two example error messages (function
baz/1and variableStateare defined):Error types that are extended by this change:
bad_inline,undefined_nif,bad_nowarn_unused_function,undefined_on_load,undefined_function,undefined_record,undefined_field,unbound_var.