Refactor the code for bit syntax construction #8697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the next commits touch code that create float segments, make sure that we have thorough tests for constructing float segments.
The first implementation of the bit syntax was done in Erlang/OTP R7B before the SMP emulator (the multi-threaded runtime system). Therefore, global variables were used to keep track of the binary being constructed. When the SMP emulator was introduced, the state of the binary being constructed needed to be local for each scheduler thread. To reduce the need for extensive rewrites, macros were used to automagically pass references to the binary construction state to the helper functions in erl_bits.c. Now bite the bullet and remove these macros. Also take the opportunity to remove the "new" part from function names. They are not exactly new.
The main optimization is breaking apart the `erts_bs_put_integer()` function into the two functions `erts_bs_put_integer_be()` and `erts_bs_put_integer_le()` to avoid runtime checks of the endianness.
bjorng
added
team:VM
CT Test Results 3 files 141 suites 50m 34s ⏱️ For more details on these failures, see this check. Results for commit 10b6aee. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
frej
reviewed
Aug 5, 2024
The `erts_copy_bits()` function is overly general, preventing the C compiler from doing any serious loop optimization. Replace it with the new `erts_copy_bits_fwd()` and `erts_copy_bits_rev()` functions.
bjorng
force-pushed
the
bjorn/erts/refactor-bit-syntax-construction
branch
from
aebac34 to
10b6aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and clean up code for the construction of integer segments of dynamic size. See the description of each commit for more details.