compiler: Limit depth of sharing state tree #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 324 suites 11m 2s ⏱️ Results for commit 28d0a97. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
frej
force-pushed
the
frej/limit-ss-depth
branch
from
c63d259 to
5d73742
Compare
|
Thanks! Looks good to me. Can you rebase onto the |
With OTP 27.0 the xmerl tests showed a markedly increased run-time. Profiling pointed to beam_ssa_ss:prune/2 as the culprit. It turns out that if there are long value derivation chains which are extended one element at a time (such as in the ss_depth_limit.erl test-case in this patch), the effective time complexity of prune will be O(n^2) where n is the number of elements in the chain. By limiting the depth of the sharing state tree, we can avoid the drastically increased run-times for the alias analysis. This is a stop-gap fix until the alias analysis can be improved to avoid this pit-fall.
frej
force-pushed
the
frej/limit-ss-depth
branch
from
5d73742 to
28d0a97
Compare
|
Rebased onto |
|
Thanks! Added to our daily builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OTP 27.0 the xmerl tests showed a markedly increased run-time. Profiling pointed to beam_ssa_ss:prune/2 as the culprit. It turns out that if there are long value derivation chains which are extended one element at a time (such as in the ss_depth_limit.erl test-case in this patch), the effective time complexity of prune will be O(n^2) where n is the number of elements in the chain.
By limiting the depth of the sharing state tree, we can avoid the drastically increased run-times for the alias analysis. This is a stop-gap fix until the alias analysis can be improved to avoid this pit-fall.