Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@param attributes lost in translation in EEP 59 #9031

Open
robertoaloi opened this issue Nov 7, 2024 · 3 comments
Open

@param attributes lost in translation in EEP 59 #9031

robertoaloi opened this issue Nov 7, 2024 · 3 comments
Assignees
Labels
help wanted Issue not worked on by OTP; help wanted from the community team:VM Assigned to OTP team VM

Comments

@robertoaloi
Copy link
Contributor

The old-style EDoc allowed the @param tag to document individual function parameters.

When applying an automatic conversion from EDoc to EEP 59 doc attributes via the edoc_doclet_markdown doclet:

edoc:application(example, [{preprocess, true}, {doclet, edoc_doclet_markdown}, {layout, edoc_layout_chunks}]).

The documentation for @param is gone. This could be surprising for some users and could lead to unexpected information loss. A possibility could be to convert the lines tagged with @param using a dotted list or equivalent.

For example, we could go from:

% @param ParamaterA This is the first parameter
% @param ParamaterB This is the second parameter

To:

* `ParameterA` This is the first parameter
* `ParameterB` This is the second parameter
@garazdawi
Copy link
Contributor

I think the code that needs to be updated is https://github.com/erlang/otp/blob/master/lib/edoc/src/edoc_layout_chunks.erl. This is not something that we will look at anytime soon, so a PR would help speed things along.

@garazdawi garazdawi added team:VM Assigned to OTP team VM help wanted Issue not worked on by OTP; help wanted from the community labels Nov 8, 2024
@robertoaloi
Copy link
Contributor Author

@garazdawi I actually suspect the issue is not limited to the @param tag, but to all tags, which seem to be excluded from the migrated docs.

@garazdawi
Copy link
Contributor

I know some are included, @since for instance. Maybe @erszcz can shed som light as it is he that wrote the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue not worked on by OTP; help wanted from the community team:VM Assigned to OTP team VM
Projects
None yet
Development

No branches or pull requests

2 participants