first version of conanfile.py, issue#38 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Pronin <[email protected]>
erikzenker
requested changes
Aug 18, 2021
| @@ -30,7 +21,7 @@ target_compile_features(inotify_unit_test PRIVATE cxx_std_17) | |||
| target_link_libraries(inotify_unit_test | |||
| PRIVATE | |||
| inotify-cpp::inotify-cpp | |||
| Boost::unit_test_framework | |||
| CONAN_PKG::boost | |||
There was a problem hiding this comment.
This will force everyone to use conan for compiling the unit test. I would keep the find package approach from cmake and add the package via conan from outside e.g:
conan install . -if build/dependencies/conan -s compiler.libcxx=libstdc++11 --build missing
cmake -S . -B build
cmake --install build/ --prefix /tmp/ -D "CMAKE_MODULE_PATH=${PWD}/build/dependencies/conan"
There was a problem hiding this comment.
Where have you seen such an approach?
There was a problem hiding this comment.
| endif() | ||
|
|
||
| include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) | ||
| conan_basic_setup(TARGETS) |
There was a problem hiding this comment.
I would prefer to not force the usage of conan. We could do it as it was done my other project: https://github.com/erikzenker/hsm#conancmake
| from conans import ConanFile, CMake, tools | ||
|
|
||
| class INotifyCpp(ConanFile): | ||
| name = "inotifycpp" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide first version of conanfile.py
Resolves issue#38
Signed-off-by: Denis Pronin [email protected]