Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle events are effectively fired twice #149

Open
FLamparski opened this issue May 25, 2016 · 2 comments
Open

Lifecycle events are effectively fired twice #149

FLamparski opened this issue May 25, 2016 · 2 comments

Comments

@FLamparski
Copy link

Events like activate-route-end are effectively fired twice. app-router dispatches them first on the route, then on itself; the events then propagate up all the way to window. Unless there is a substantial difference between the two events, dispatching the event just on the route should suffice.

@jmalonzo
Copy link
Collaborator

Do you have a simple test we can look into where these are triggered twice?

@FLamparski
Copy link
Author

I'll try to come up with something, but so far I've noticed that this might be browser-specific (happens in Chrome, in Firefox the events don't seem to propagate up from the elements they've been dispatched on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants