New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adam mhat and vhat updates #90

Open

shivamsharma01 opened this issue Feb 25, 2021 · 0 comments

shivamsharma01 commented Feb 25, 2021

ML-From-Scratch/mlfromscratch/deep_learning/optimizers.py

Line 125 in a2806c6

m_hat = self.m / (1 - self.b1)

While updating mhat and vhat in Adam, shouldn't we also consider the update number(t) for the weight decay?

m_hat = m/(1 - pow(beta,t))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment