-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce moz-webgpu-cts process-reports
#13
Labels
Comments
ErichDonGubler
changed the title
Add
Add Oct 19, 2023
moz-webgpu-cts adjust-exps <wptreport.json glob>
moz-webgpu-cts adjust-exps <wptreport.json glob>
for new permanent test outcomes
ErichDonGubler
added
enhancement
New feature or request
A-parsing-metadata
A-webgpu-cts
labels
Oct 19, 2023
ErichDonGubler
moved this from Todo
to In Progress
in Automate WebGPU CTS adjustments for Firefox
Oct 19, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
changed the title
Add
Add Oct 23, 2023
moz-webgpu-cts adjust-exps <wptreport.json glob>
for new permanent test outcomesmoz-webgpu-cts adjust-exps --stage=permas <wptreport.json paths>
for new permanent test outcomes
ErichDonGubler
changed the title
Add
Add Oct 23, 2023
moz-webgpu-cts adjust-exps --stage=permas <wptreport.json paths>
for new permanent test outcomesmoz-webgpu-cts adjust-exps --stage=permas …
for new permanent test outcomes
This comment was marked as off-topic.
This comment was marked as off-topic.
ErichDonGubler
changed the title
Add
Add Oct 24, 2023
moz-webgpu-cts adjust-exps --stage=permas …
for new permanent test outcomesmoz-webgpu-cts adjust-exps --mode=permas …
for new permanent test outcomes
ErichDonGubler
changed the title
Add
Add Oct 24, 2023
moz-webgpu-cts adjust-exps --mode=permas …
for new permanent test outcomesmoz-webgpu-cts adjust-exps --mode=match-reports…
for new permanent test outcomes
ErichDonGubler
changed the title
Add
Introduce Oct 24, 2023
moz-webgpu-cts adjust-exps --mode=match-reports…
for new permanent test outcomesmoz-webgpu-cts adjust-exps
with --mode=match-reported…
ErichDonGubler
changed the title
Introduce
Introduce Oct 24, 2023
moz-webgpu-cts adjust-exps
with --mode=match-reported…
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported…
ErichDonGubler
changed the title
Introduce
Introduce Oct 24, 2023
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported…
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported …
ErichDonGubler
changed the title
Introduce
Introduce Oct 24, 2023
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported …
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported
ErichDonGubler
changed the title
Introduce
Introduce Oct 24, 2023
moz-webgpu-cts adjust-exps
with --on-conflict=change-to-reported
moz-webgpu-cts process-reports
with --on-conflict=change-to-reported
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
changed the title
Introduce
Introduce Oct 26, 2023
moz-webgpu-cts process-reports
with --on-conflict=change-to-reported
moz-webgpu-cts process-reports
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
github-project-automation
bot
moved this from In Progress
to Done
in Automate WebGPU CTS adjustments for Firefox
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
As the developer of Firefox implementation of WebGPU, it's sometimes difficult to quickly adjust test expectations after I make changes to Firefox. CTS comprises a large set of tests and files that I work with, and it can be time-consuming and even error-prone to find the right places in files to edit by hand when I receive WPT reports from CI.
I would like tool assistance in adjusting expectations in the correct locations, given a set of WPT reports in JSON format (i.e.,
wptreport.json
) files that are provided by CTS runs in CI (./mach wpt --log-wptreport=…
). I recognize that there are different heuristics that I may want to use for adjusting expected outcomes, so I'll offer users their choice of adjustment heuristic. The data I'll use is:testing/web-platform/mozilla/meta/webgpu
. Per test and subtest, there will be a set of expected outcomes per platform.webgpu
test path that have actual outcomes on a specific platform noted. These can be combined to form a set of actual outcomes in a structure otherwise very similar to (1).Overall flow of
moz-webgpu-cts process-reports
The flow of the tool should be:
./mach wpt-fetch-logs try:2639473c8ba1d33e13a3108db7660cc8cbed91f5
or (eventually) Addmoz-webgpu-cts dl-reports
subcommand #18.moz-webgpu-cts process-reports --preset=… <wpt-report-json-paths…>
--preset=…
here. This is a required argument to specify a heuristic for making changes based on reports. Presets are intended to be very coarse grained configurations that match typical workflows for convenience. We do not provide other options for finer-grained configuration at this time, but we plan to do so, and track progress on such at Tracking issue:moz-webgpu-cts update-expected
options #26.--glob <glob>
options, which correspond towax
globs.wptreport.json
. If any paths fail validation, emit a warning onstderr
.--preset=…
to determine how to react in each comparison case.fmt
subcommand (see Implementmoz-webgpu-cts fmt
for normalizing expectation formatting #8).Technical notes
Fortunately, we have a lot of good data to work with. We already implement parsing of WPT metadata as of #5, so the remaining work is:
moz-webgpu-cts fmt
to restructure metadata as described in "Overall flow ofmoz-webgpu-cts process-reports
", requirement 4.ii. EDIT: Done with Normalize outcome order for tests and subtests #39 and Impose total ordering on sections in WebGPU CTS files #43.The text was updated successfully, but these errors were encountered: