Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finding unused dst dirs fails because of trailing slash "/" mismatch #919

Open
FlyWieEinAirplane opened this issue Sep 11, 2021 · 1 comment

Comments

@FlyWieEinAirplane
Copy link

unused_dirs = [d for d in dst_dirs if d not in dir2ph.keys()]

var d will be in the format of "/mnt/destDir"
while each key in dir2ph.keys() will be in format "/mnt/destDir/"
Because of this, all directories will be in the ununsed_dirs array.

@FlyWieEinAirplane FlyWieEinAirplane changed the title finding unused dst dirs fails because of trailing slash "/" finding unused dst dirs fails because of trailing slash "/" mismatch Sep 11, 2021
altendky added a commit to altendky/plotman that referenced this issue Sep 12, 2021
long term just use pathlib.Path...

ericaltendorf#919
@altendky
Copy link
Collaborator

I really need to get to using pathlib someday... it wouldn't have this issue. But, thank you for catching this and reporting it with an explanation. I'll do a quick patchup for now. You were observing this in the running of plotman I would guess? With madMAx?

Any chance you could test out #920?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants