Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about LoRA alpha #5

Open
vishaal27 opened this issue Sep 10, 2023 · 1 comment
Open

Question about LoRA alpha #5

vishaal27 opened this issue Sep 10, 2023 · 1 comment

Comments

@vishaal27
Copy link

Hi, thanks for your great work. I noticed that in your scripts, you hard-coded the lora alpha to be 128 and the rank r to be 4 (therefore leading to a scaling factor of 32):

'''
LoRA setting
'''
self.lora_moe_lambda = 1.0
self.lora_moe_act = 'linear'
self.lora_r_dropout = None
self.lora_attn_dim = 4
self.lora_moe = 0
self.lora_attn_alpha=128

Was there a principled justification for these choices? I am just wondering if you did any tuning on these values to suggest what would be good values to use.

@jkooy
Copy link
Collaborator

jkooy commented Sep 17, 2023

Hi, thanks for the interests! The setting is inherited from LoRA's official development code:
https://github.com/microsoft/LoRA/tree/snapshot-9-15-2021
https://github.com/microsoft/LoRA/blob/snapshot-9-15-2021/src/model.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants